fix: notification click routing race conditions#82
Merged
GraysonCAdams merged 3 commits intomainfrom Mar 4, 2026
Merged
Conversation
Defer clipOverlaySignal to the next event-loop task after ondismiss() so the popstate from history.back() settles before ClipOverlay mounts. Also handle non-feed-page clicks by navigating with deep-link params.
Ensures the service worker stays alive until client navigation completes, preventing silent navigation failures on some platforms.
Use goto() directly with eslint-disable for no-navigation-without-resolve since resolve() doesn't support query params. Keeps file under 500 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
history.back()from overlay cleanup was firing a popstate that immediately dismissed the newly-mounted ClipOverlayclipOverlaySignalto the next event-loop task so popstate settles before ClipOverlay mountsfocus()andnavigate()in service workernotificationclickhandler so the SW stays alive until navigation completesTest plan