fix: android push notification routing#86
Merged
GraysonCAdams merged 4 commits intomainfrom Mar 5, 2026
Merged
Conversation
client.navigate() in the service worker causes a full page reload that races with SvelteKit hydration, leaving the overlay open with no video. Switch to postMessage so the layout can route via clipOverlaySignal (same path that works for in-app activity notifications) or goto() for client-side navigation when on a different page.
…rhf-9h96) Trivy container scan flagged tar 7.5.7 (bundled with npm in node:24-slim). Update to tar@latest inside npm's own node_modules to resolve the hardlink path traversal advisory.
The previous approach of running npm install inside npm's own directory failed because npm's package.json references private packages. Instead, update npm itself to latest which includes patched tar.
tar 7.5.10 isn't available in any npm release yet. Add the GHSA ID to .trivyignore alongside existing npm bundled CVEs. Revert the npm global update since it only reached 7.5.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client.navigate()withpostMessage()in service worker'snotificationclickhandler to avoid full-page reload race conditions on Android PWANOTIFICATION_CLICKmessage listener in root layout that routes viaclipOverlaySignal(same working path as in-app activity notifications) orgoto()for cross-page navigationTest plan