Skip to content

ValueRef #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 88 commits into from
Aug 1, 2015
Merged

ValueRef #20

merged 88 commits into from
Aug 1, 2015

Conversation

3Hren
Copy link
Owner

@3Hren 3Hren commented Jul 13, 2015

  • Implement decoding function.
    • Nil
    • Bool,
    • Signed integers
    • Unsigned integers
    • Floats
    • Strings
    • Binary
    • Arrays
    • Maps
    • Exts
    • Get rid of manual counting bytes number consumed.
    • Make more generic for [u8], Vec, Cursor<&[u8]>, Cursor<Vec>, ... all wrappers, where get_ref() -> &[u8].
  • Implement encoding function.
    • Nil
    • Bool,
    • Signed integers
    • Unsigned integers
    • Floats
    • Strings
    • Binary
    • Arrays
    • Maps
    • Exts
  • Write documentation for both of them.
  • Write several examples.
  • Conversion into a Value (using Into trait or something like this).
  • Implement Borrow (or something like this) trait.
  • Error category for decoding module.
  • Error category for encoding module.
  • Display trait for decoding Error.
  • Display trait for encoding Error.
  • Error trait for decoding Error.
  • Error trait for encoding Error.
  • Modules review and visibility check.

@3Hren 3Hren mentioned this pull request Jul 13, 2015
Closed
4 tasks
3Hren added 28 commits July 13, 2015 23:20
@3Hren
[ValueRef] Planning.
a8e480f
@3Hren
ValueRef: marker error conversion.
427ada8
@3Hren
ValueRef: buffer fill error conversion.
3aff372
@3Hren
Doc: minor update.
9baeafa
@3Hren
ValueRef: handle EOF while reading length.
ff75c0e
@3Hren
Planning: minor notice.
17a770a
@3Hren
ValueRef: handling UTF-8 errors.
65282fd
@3Hren
Doc: more comments.
f6c797c
@3Hren
ValueRef: decoding fixed strings.
32b0c6f 
Green light -> refactoring.
@3Hren
Marker: rename planning.
5349d36
@3Hren
Wording.
60ac905
@3Hren
Refactoring: code decomposition.
bcc34fd
@3Hren
Cleanup: minor.
b852ce9
@3Hren
Doc: wording.
cb7b6c6
@3Hren
ValueRef: decoding strings with 2-byte length.
cbbe83b
@3Hren
ValueRef: decoding all types of strings.
ad90960 
Green light.
@3Hren
ValueRef: functional decomposition.
1bae03c 
Here we have the first untestable on x86_64 error case - an `u16/u32 as
usize` overflow, which may only trigger on systems with pointer size
less than u16/u32. I'm not sure what to do in that case, so it
definetely need to discuss about.
@3Hren
ValueRef: naive bin8 decoding.
5a2fee0
@3Hren
ValueRef: decomposition.
dc3e6f9
@3Hren
Misc: code reuse.
b2a29de
@3Hren
ValueRef: done with binary decoding.
270ae56
@3Hren
ValueRef: ext1 decoding.
83adebd
@3Hren
ValueRef: decoding all fixed ext types.
07b2357
@3Hren
ValueRef: decoding all types of exts now.
54ed999
@3Hren
ValueRef: map decoding, first blood.
867c6bf
@3Hren
ValueRef: map - code clean.
c413ca3
@3Hren
Misc: minor code style.
3aab5ba
@3Hren
Bench: value ref benchmark added.
552d190
@3Hren
Copy link
Owner Author

3Hren commented Aug 1, 2015

I've almost done!

Several lines of documentation, some examples and this will be merged.

3Hren added 9 commits August 1, 2015 11:24
@3Hren
Doc: to_owned method has been documented.
ae60f1e 
With example.
@3Hren
Misc: style.
b3e30e6
@3Hren
ValueRef: documentation added.
b3c4d8d 
Added documentation with an example for `write_value_ref` function.
@3Hren
Misc: planning.
f78528f
@3Hren
Misc: wording.
51a6ea2
@3Hren
ValueRef: more documentation for decoding.
01fa09c 
Added some documentation with examples for `read_value_ref` function.
@3Hren
Misc: one task less.
86cf871
@3Hren
Changelog: merge.
b395cba
@3Hren
Misc: trait renaming.
93b5100 
BufRead is now called BorrowRead to avoid naming colisions.
@3Hren
Copy link
Owner Author

3Hren commented Aug 1, 2015

LGTM!

3Hren added a commit that referenced this pull request Aug 1, 2015
@3Hren
Merge pull request #20 from 3Hren/feature/value-ref
b661620 
ValueRef: done.
@3Hren 3Hren merged commit b661620 into master Aug 1, 2015
@3Hren 3Hren deleted the feature/value-ref branch August 1, 2015 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@3Hren