fix(get-terraform-dir): Resolve error when multiple directories returned#102
Merged
chris3ware merged 6 commits intomainfrom Aug 29, 2024
Merged
fix(get-terraform-dir): Resolve error when multiple directories returned#102chris3ware merged 6 commits intomainfrom
chris3ware merged 6 commits intomainfrom
Conversation
This release uses the `matrix` parameter to replace `json` and `escape_json`
The first step will output a JSON object which can be used to define a matrix strategy for calling workflows. The second step will output text that is used in the job summary. Having two steps maybe inefficient, but converting the JSON into text, particularly with multiple directories, was proving a challenge. Better to keep it simple when the action will natively output the formats required.
Required workflow so needs to run.
chris3ware
force-pushed
the
fix-get-tf-dir
branch
from
7006461 to
ca7178a
Compare
chris3ware
approved these changes
Aug 29, 2024
3ware-release Bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
## [3.1.2](v3.1.1...v3.1.2) (2024-08-29) ### Bug Fixes * **get-terraform-dir:** Resolve error when multiple directories returned ([#102](#102)) ([b0ed4ae](b0ed4ae))
Contributor
|
This PR is included in version 3.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow was failing when multiple terraform directories were returned when formatting the output for the summary steps.
The step formatting the JSON output has been removed and a second action has been added that returns plain text output list of directory names. This is working as expected.
Also added
synchronizeto activity type in the pr-title workflow.