Support custom cost factors #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
Feb 22, 2018
|
|
||
| enterType(type) { | ||
| leaveField() { | ||
| this.costFactor /= this.getFieldCostFactor(); |
There was a problem hiding this comment.
every time, i forget this operator exists
jquense
reviewed
Feb 22, 2018
| item: { type: Item }, | ||
| expensiveItem: { | ||
| type: Item, | ||
| getCost: () => 50, |
There was a problem hiding this comment.
is this safe to extend like this?
There was a problem hiding this comment.
well, it works, doesn’t it?
|
How is this going to work if I write in the SDL? |
itajaja
reviewed
Feb 23, 2018
Yeah for sure, what if one of my fields has to do 10 db queries instead of the usual 1? type Bla {
normalField: String # Cheap
someExtremelyExpensiveField: SomeExtremelyExpensiveObject # Much more expensive
} |
|
wouldn't that be modeled by a constant cost on the field? |
|
I can't think of a use case for cost factor on a non-list field, but I don't think it really matters. I don't see the harm in keeping it around. |
|
@mxstbr I just added SDL support in the latest commit on this PR. |
itajaja
approved these changes
Feb 24, 2018
|
Released in v0.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.