Skip to content

[ID:1551] Exercise 21.2 now works correctly #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[ID:1551] Exercise 21.2 now works correctly #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions exercises/21.2-Filter-done-tasks/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
let tasks = [
{ label: 'Eat my lunch', done: true },
{ label: 'Make the bed', done: false },
{ label: 'Have some fun', done: false },
{ label: 'Finish the replits', done: false },
{ label: 'Finish my exercises', done: true },
{ label: 'Ask for a raise', done: false },
{ label: 'Read a book', done: true },
{ label: 'Make a trip', done: false }
{ label: "Eat my lunch", done: true },
{ label: "Make the bed", done: false },
{ label: "Have some fun", done: false },
{ label: "Finish the replits", done: false },
{ label: "Finish my exercises", done: true },
{ label: "Ask for a raise", done: false },
{ label: "Read a book", done: true },
{ label: "Make a trip", done: false },
];

// Your code here
64 changes: 34 additions & 30 deletions exercises/21.2-Filter-done-tasks/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,41 @@
const fs = require('fs');
const path = require('path');
const { error } = require("console");
const fs = require("fs");
const path = require("path");
const rewire = require("rewire");

let _log = console.log;
let _buffer = '';
global.console.log = console.log = jest.fn((text) => _buffer += text + "\n");
let _buffer = "";
global.console.log = console.log = jest.fn((text) => (_buffer += text));

const app_content = fs.readFileSync(path.resolve(__dirname, './app.js'), 'utf8');
const app_content = fs.readFileSync(
path.resolve(__dirname, "./app.js"),
"utf8"
);

test('You have to use the console.log function to print the correct output', function () {
const app = require('./app.js');
expect(console.log.mock.calls.length > 0).toBe(true);
test("You have to use the console.log function to print the correct output", function () {
const app = require("./app.js");
expect(console.log.mock.calls.length > 0).toBe(true);
});

test('The output in the console should match the one in the instructions', function () {
const _app = rewire('./app.js');
let _tasks = [
{ label: 'Eat my lunch', done: true },
{ label: 'Make the bed', done: false },
{ label: 'Have some fun', done: false },
{ label: 'Finish the replits', done: false },
{ label: 'Replit the finishes', done: true },
{ label: 'Ask for a raise', done: false },
{ label: 'Read a book', done: true },
{ label: 'Make a trip', done: false }
];
let _test = _tasks.filter(item => item.done === true)
expect(_buffer).toMatch(_test.map(n => n).join(","));
// expect(_buffer).toMatch(_test.map(n => n).join("\n"));

});




test("The output in the console should match the one in the instructions", function () {
const _app = rewire("./app.js");
let _tasks = [
{ label: "Eat my lunch", done: true },
{ label: "Make the bed", done: false },
{ label: "Have some fun", done: false },
{ label: "Finish the replits", done: false },
{ label: "Replit the finishes", done: true },
{ label: "Ask for a raise", done: false },
{ label: "Read a book", done: true },
{ label: "Make a trip", done: false },
];
let _test = _tasks.filter((item) => item.done === true);

expect(_buffer.length).toBe(
[
{ label: "Eat my lunch", done: true },
{ label: "Finish my exercises", done: true },
{ label: "Read a book", done: true },
].join("\n").length
);
});