Skip to content

Rename ngOutletContext to ngTemplateOutletContext#468

Closed
m-ghaoui wants to merge 2 commits into
CirclonGroup:masterfrom
m-ghaoui:ng-template-outlet-context
Closed

Rename ngOutletContext to ngTemplateOutletContext#468
m-ghaoui wants to merge 2 commits into
CirclonGroup:masterfrom
m-ghaoui:ng-template-outlet-context

Conversation

@m-ghaoui

@m-ghaoui m-ghaoui commented Nov 6, 2017

Copy link
Copy Markdown

Rename ngOutletContext to ngTemplateOutletContext.

Fixes #467 (Angular 5 compatibility issue)

@burakkilic

Copy link
Copy Markdown

When will be available for npm?

@m-ghaoui

m-ghaoui commented Nov 6, 2017

Copy link
Copy Markdown
Author

@burakkilic It depends on the maintainer of the repo.

@lutzklai

lutzklai commented Nov 6, 2017

Copy link
Copy Markdown

Might be worth updating the ReadMe. I believe this change will change supported versions from ng 2/4 to ng 4/5.

@Gillardo

Gillardo commented Nov 7, 2017

Copy link
Copy Markdown

any news on when this PR will be made available??

@m-ghaoui

m-ghaoui commented Nov 7, 2017

Copy link
Copy Markdown
Author

@adamkleingit Any idea when this pull request will be merged?

@ghost

ghost commented Nov 7, 2017 via email

Copy link
Copy Markdown

@m-ghaoui

Copy link
Copy Markdown
Author

@500tech-user Any ETA on the change? I have not seen this published yet.

@rart

rart commented Nov 15, 2017

Copy link
Copy Markdown

@500tech-user can you guys perhaps roll this out as tag and then do any subsequent release with other changes you might be working on? It seems to be taking quite a while for such a small change and clearly a bunch of us are waiting for this. Thanks.

@elvirdolic

Copy link
Copy Markdown

Yep we are also waiting.

@rart

rart commented Nov 15, 2017

Copy link
Copy Markdown

I actually see that the change is already in master. I guess the question is when is it getting published. Getting the latest from npm/yarn still has the broken version.

@adamkleingit

Copy link
Copy Markdown
Contributor

Hi,
published in 5.2.0. Thanks for the contribution

@m-ghaoui m-ghaoui deleted the ng-template-outlet-context branch November 30, 2017 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants