Skip to content

Conversation

@phiSgr
Copy link
Collaborator

@phiSgr phiSgr commented Oct 27, 2025

Note

Adds end-to-end support for ClickHouse S3, Buffer, and Distributed engines (CLI, TS/Py SDKs, codegen), with runtime env credential resolution, docs, and tests (incl. e2e).

  • Infrastructure (Rust CLI):
    • Add S3, Buffer, Distributed engine configs, parsing/serialization, non-alterable hash, and DDL generation in clickhouse/queries.rs.
    • Enforce clause support: MergeTree-only ORDER BY/PRIMARY KEY/SAMPLE BY; allow PARTITION BY for S3.
    • Factor resolve_s3_credentials and apply to S3/S3Queue in partial_infrastructure_map.rs.
  • Codegen:
    • TypeScript/Python generators emit engine-specific fields for S3/Buffer/Distributed and honor clause constraints/settings.
  • SDKs:
    • TS: extend ClickHouseEngines and OlapConfig unions; map engine configs in dmv2/internal.ts.
    • Python: add S3Engine, BufferEngine, DistributedEngine; update internal serialization and validation to restrict unsupported clauses.
  • Docs:
    • Add sections for S3 (direct access), Buffer, and Distributed engines (TS & Py), with config examples and caveats; clarify S3 vs S3Queue.
  • Tests:
    • New e2e S3 engine env-var resolution tests (TS/Py) and Buffer table verification in template tests.
    • Unit tests updated to validate new engines and clause restrictions; templates export new S3/Buffer examples.
  • Misc:
    • Minor test comment tweaks to unify S3/S3Queue env var naming.

Written by Cursor Bugbot for commit eb4f916. This will update automatically on new commits. Configure here.

@linear
Copy link

linear bot commented Oct 27, 2025

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
framework-docs Ready Ready Preview Comment Oct 28, 2025 10:46pm

@phiSgr phiSgr force-pushed the george/eng-986-support-engines-other-than-those-in-the-mergetree-family branch from d3577d2 to 4457b32 Compare October 27, 2025 18:28
…t-engines-other-than-those-in-the-mergetree-family
…t-engines-other-than-those-in-the-mergetree-family
@phiSgr phiSgr marked this pull request as ready for review October 28, 2025 18:28
Copy link
Collaborator

@callicles callicles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about interop with another feature

@callicles
Copy link
Collaborator

Missing docs !

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@phiSgr phiSgr enabled auto-merge October 28, 2025 22:46
@phiSgr phiSgr added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@phiSgr phiSgr added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit 762db88 Oct 28, 2025
52 checks passed
@phiSgr phiSgr deleted the george/eng-986-support-engines-other-than-those-in-the-mergetree-family branch October 28, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants