-
Notifications
You must be signed in to change notification settings - Fork 25
engines: buffer, s3, distributed #2908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
phiSgr
merged 25 commits into
main
from
george/eng-986-support-engines-other-than-those-in-the-mergetree-family
Oct 28, 2025
Merged
engines: buffer, s3, distributed #2908
phiSgr
merged 25 commits into
main
from
george/eng-986-support-engines-other-than-those-in-the-mergetree-family
Oct 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
d3577d2 to
4457b32
Compare
…t-engines-other-than-those-in-the-mergetree-family
…t-engines-other-than-those-in-the-mergetree-family
…ose-in-the-mergetree-family
callicles
approved these changes
Oct 28, 2025
Collaborator
callicles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment about interop with another feature
Collaborator
|
Missing docs ! |
…ose-in-the-mergetree-family
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds end-to-end support for ClickHouse S3, Buffer, and Distributed engines (CLI, TS/Py SDKs, codegen), with runtime env credential resolution, docs, and tests (incl. e2e).
S3,Buffer,Distributedengine configs, parsing/serialization, non-alterable hash, and DDL generation inclickhouse/queries.rs.ORDER BY/PRIMARY KEY/SAMPLE BY; allowPARTITION BYforS3.resolve_s3_credentialsand apply toS3/S3Queueinpartial_infrastructure_map.rs.S3/Buffer/Distributedand honor clause constraints/settings.ClickHouseEnginesandOlapConfigunions; map engine configs indmv2/internal.ts.S3Engine,BufferEngine,DistributedEngine; update internal serialization and validation to restrict unsupported clauses.S3(direct access),Buffer, andDistributedengines (TS & Py), with config examples and caveats; clarify S3 vs S3Queue.Written by Cursor Bugbot for commit eb4f916. This will update automatically on new commits. Configure here.