-
Notifications
You must be signed in to change notification settings - Fork 25
fix: make table diffing backwards compatible #2918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
callicles
reviewed
Nov 1, 2025
a492935 to
63ab4d0
Compare
Collaborator
callicles
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

handle
remote_planwhere the remote IDNote
Make infra map diff/plan compatible with old table IDs (no DB prefix) and cross-DB IDs, add default_database to proto, and add E2E backward-compat tests in CI.
Table::id(default_database)across diff/reality checks; add helperfind_table_from_infra_mapto match legacy IDs without DB prefix.InfrastructureMap.diff_tables(_with_strategy)now keys by IDs and uses targetdefault_databasefor comparisons; filters adds/removes via new matching.reconcile_with_realitynormalizes legacy map keys (rehashes IDs with DB) and updatesdefault_databasefrom project.default_databaseto proto (InfrastructureMap) and round-trip it in serialization.primary_keyflags when engine doesn’t support ORDER BY; propagate table TTL/index settings; compute IDs with DB.databaseinTableWithUnsupportedType; richer logging for column modify; warn (not debug) on drop+create cases in diff strategy; refine PK/engine/partition handling.backward-compatibility.test.ts) and new GitHub Actions jobs for TS and Python; include them in final status gate.Written by Cursor Bugbot for commit 7a2eb27. This will update automatically on new commits. Configure here.