-
Notifications
You must be signed in to change notification settings - Fork 25
ENG-1162: fix importing default column functions #2956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LucioFranco
merged 8 commits into
main
from
spr/lucio/eng-1162-fix-importing-default-column-functions
Nov 7, 2025
Merged
ENG-1162: fix importing default column functions #2956
LucioFranco
merged 8 commits into
main
from
spr/lucio/eng-1162-fix-importing-default-column-functions
Nov 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using jj-spr 1.3.6-beta.1
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
LucioFranco
commented
Nov 6, 2025
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
phiSgr
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Ensures ClickHouse DEFAULT expressions are used as-is (no extra quoting) in DDL/ALTER generation and adds Python/TypeScript e2e tests verifying db-pull roundtrip with function defaults.
ALTER TABLE ... MODIFY COLUMNandCREATE TABLEpaths (apps/framework-cli/src/infrastructure/olap/clickhouse.rs,.../queries.rs).'...', numbers, and SQL functions (xxHash64(_id),now(),today()).MODIFY COLUMNandCREATE TABLEflows.apps/framework-cli-e2e/test/db-pull-defaults.test.ts).default_kindtodefault_type(apps/framework-cli-e2e/test/utils/database-utils.ts).Written by Cursor Bugbot for commit 3ab0104. This will update automatically on new commits. Configure here.