Skip to content

Conversation

@LucioFranco
Copy link
Contributor

@LucioFranco LucioFranco commented Nov 6, 2025

Note

Ensures ClickHouse DEFAULT expressions are used as-is (no extra quoting) in DDL/ALTER generation and adds Python/TypeScript e2e tests verifying db-pull roundtrip with function defaults.

  • ClickHouse DDL generation (Rust):
    • Use defaults verbatim in ALTER TABLE ... MODIFY COLUMN and CREATE TABLE paths (apps/framework-cli/src/infrastructure/olap/clickhouse.rs, .../queries.rs).
    • Remove extra formatting/quoting for defaults; preserve literals '...', numbers, and SQL functions (xxHash64(_id), now(), today()).
    • Add unit tests for function defaults in both MODIFY COLUMN and CREATE TABLE flows.
  • E2E tests:
    • Add comprehensive Python and TypeScript db-pull tests validating generated model defaults and successful migrate/apply with function and literal defaults (apps/framework-cli-e2e/test/db-pull-defaults.test.ts).
    • Include special-character default cases.
  • Schema utils:
    • Update ClickHouse schema introspection field from default_kind to default_type (apps/framework-cli-e2e/test/utils/database-utils.ts).

Written by Cursor Bugbot for commit 3ab0104. This will update automatically on new commits. Configure here.

Created using jj-spr 1.3.6-beta.1
@linear
Copy link

linear bot commented Nov 6, 2025

@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
framework-docs Ready Ready Preview Comment Nov 7, 2025 3:54pm
moosestack-framework-docs-v2 Ready Ready Preview Comment Nov 7, 2025 3:54pm

Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
@LucioFranco LucioFranco added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit be90c8d Nov 7, 2025
41 checks passed
@LucioFranco LucioFranco deleted the spr/lucio/eng-1162-fix-importing-default-column-functions branch November 7, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants