-
Notifications
You must be signed in to change notification settings - Fork 31
feature: EthHashInfo add custom avatar #112
Conversation
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
fernandomg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not convinced about the prop name, but it's ok. Can be changed in the future.
|
The thing that screw me more here is the withAvatar prop, that can be used as a boolean to use Identicon or as a string to pass a link. But it's a weird use for a prop that can behave as a simple boolean or as a string parameter. I would flag it as 2 separate props:
@fernandomg @nicosampler what do you think? |
|
I think that will be much clear, I was trying to use only one prop for everything. But You and Fer found that confusing, so your proposal makes sense to me. |
|
Travis automatic deployment: |
Needed it in 5afe/safe-react#1638.