Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Generate Jest snapshots from Storybook stories #116

Merged
merged 6 commits into from
Apr 13, 2021
Merged

Generate Jest snapshots from Storybook stories #116

merged 6 commits into from
Apr 13, 2021

Conversation

@katspaugh
Copy link
Member

@katspaugh katspaugh commented Apr 12, 2021

This PR adds simple regression testing based on Jest snapshots. They are automatically generated from the Storybook stories.

When changing a component implementation, this will help us find potential bugs.

What do you guys think?

Caveats:

  • Portals have to be mocked (see tests/jest-runtime.js)
  • The ScrollbarSize module from Material UI doesn't work in tests, so I had to replace the scrollable tabs with full-width tabs in the Tabs story.

@katspaugh katspaugh self-assigned this Apr 12, 2021
@ghost
Copy link

ghost commented Apr 12, 2021

Travis automatic deployment:
https://pr116--safereactcomponents.review.gnosisdev.com

@5afe 5afe deleted a comment from github-actions bot Apr 12, 2021
@5afe 5afe deleted a comment from github-actions bot Apr 12, 2021
@ghost
Copy link

ghost commented Apr 12, 2021

Travis automatic deployment:
https://pr116--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Apr 12, 2021

Travis automatic deployment:
https://pr116--safereactcomponents.review.gnosisdev.com

nicosampler
nicosampler reviewed Apr 12, 2021
View reviewed changes
@nicosampler
Copy link
Contributor

nicosampler commented Apr 12, 2021

This is awesome, we have talked about this many times, but we never got the time to do it.

@nicosampler nicosampler requested a review from fernandomg April 12, 2021 11:12
nicosampler
nicosampler reviewed Apr 12, 2021
View reviewed changes
nicosampler
nicosampler reviewed Apr 12, 2021
View reviewed changes
nicosampler
nicosampler approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@nicosampler nicosampler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @katspaugh. 💪

@ghost
Copy link

ghost commented Apr 12, 2021

Travis automatic deployment:
https://pr116--safereactcomponents.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Apr 12, 2021

Travis automatic deployment:
https://pr116--safereactcomponents.review.gnosisdev.com

@5afe 5afe deleted a comment from github-actions bot Apr 12, 2021
@github-actions
Copy link

github-actions bot commented Apr 12, 2021 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Apr 12, 2021

Travis automatic deployment:
https://pr116--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Apr 12, 2021

Travis automatic deployment:
https://pr116--safereactcomponents.review.gnosisdev.com

@katspaugh katspaugh merged commit 6cc34ae into development Apr 13, 2021
@katspaugh katspaugh deleted the snapshots branch April 13, 2021 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dasanra dasanra Awaiting requested review from dasanra

@alongoni alongoni Awaiting requested review from alongoni

@fernandomg fernandomg Awaiting requested review from fernandomg

1 more reviewer

@nicosampler nicosampler nicosampler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@katspaugh katspaugh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@katspaugh @nicosampler