Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@alongoni
Copy link
Contributor

@alongoni alongoni commented Apr 23, 2021

Closes #83
Now we can set individually the icon and text colors.
image

@alongoni alongoni requested a review from nicosampler April 23, 2021 20:38
@alongoni alongoni self-assigned this Apr 23, 2021
@alongoni alongoni requested a review from katspaugh April 23, 2021 20:39
@github-actions
Copy link

github-actions bot commented Apr 23, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Apr 23, 2021

Travis automatic deployment:
https://pr124--safereactcomponents.review.gnosisdev.com

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Please pull from development and update the snapshots with yarn test -u. This'll fix the tests.
Let me know if there's any issue with that.

@ghost
Copy link

ghost commented Apr 26, 2021

Travis automatic deployment:
https://pr124--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Apr 26, 2021

Travis automatic deployment:
https://pr124--safereactcomponents.review.gnosisdev.com

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Agu!

@alongoni alongoni requested a review from dasanra April 26, 2021 19:37
@ghost
Copy link

ghost commented Apr 27, 2021

Travis automatic deployment:
https://pr124--safereactcomponents.review.gnosisdev.com

@katspaugh
Copy link
Member

I've tested that it works and doesn't break anything. 👍

@katspaugh katspaugh merged commit 6a253f8 into development Apr 29, 2021
@katspaugh katspaugh deleted the issue#83/IconText-styles branch April 29, 2021 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Components] IconText

3 participants