Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@matextrem
Copy link
Contributor

As part of #2234, we added 2 new icons (export/import)

@matextrem matextrem requested review from dasanra and katspaugh May 6, 2021 19:41
@matextrem matextrem self-assigned this May 6, 2021
@matextrem matextrem added the enhancement New feature or request label May 6, 2021
@github-actions
Copy link

github-actions bot commented May 6, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented May 6, 2021

Travis automatic deployment:
https://pr131--safereactcomponents.review.gnosisdev.com

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you run prettier? Or whitelist the icon files if we don't want to prettify them.

Copy link
Contributor

@alongoni alongoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @matextrem! we have to add the new icons in the icon.stories.tsx file, so that they appear in the icon list:
image

Thanks!!

@katspaugh
Copy link
Member

Need to update the snapshots with yarn test -u 😉

@matextrem matextrem requested review from alongoni and katspaugh May 7, 2021 15:27
@ghost
Copy link

ghost commented May 7, 2021

Travis automatic deployment:
https://pr131--safereactcomponents.review.gnosisdev.com

Copy link
Contributor

@alongoni alongoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matextrem matextrem merged commit 0e4fcd6 into development May 10, 2021
@matextrem matextrem deleted the feature/new-icons branch May 10, 2021 14:04
@dasanra dasanra mentioned this pull request Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants