Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@yagopv
Copy link
Member

@yagopv yagopv commented Nov 2, 2021

In the <Table /> component the icon to sort the rows is always visible. Sometimes is nice to hide it in order to indicate the user about the column not being sortable.

Would like to use this feature to enhance the Table showed in the Drain safe app when implementing this feature safe-global/safe-react-apps#166

@yagopv yagopv requested review from DaniSomoza and dasanra November 2, 2021 14:28
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

# Conflicts:
#	tests/__snapshots__/storybook.test.js.snap
@yagopv yagopv merged commit 054937b into main Nov 4, 2021
@yagopv yagopv deleted the feature/allow-hide-sort-icon-in-tables branch November 4, 2021 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants