Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Nov 19, 2021

What it solves

Storybook automatic build was lost because it wasn't migrated from Travis. In this PR we restore automated builds on each PR and also the action to create the production build each time we create a new release to be published in https://components.gnosis-safe.io

It also includes some dependency bump and optimization

@github-actions
Copy link

github-actions bot commented Nov 19, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

📚Storybook review

@DaniSomoza
Copy link
Contributor

Two of the files do not have a new line at the end of the file: :
.github/workflows/deploy-storybook.yml
scripts/github/prepare_production_deployment.sh

Captura de pantalla 2021-11-22 a las 13 17 01

@DaniSomoza
Copy link
Contributor

Keep in mind that In this PR, The Textfield component is Broken:

https://pr168--safereactcomponents.review.gnosisdev.com/?path=/docs/inputs-textfield--simple-text-field

Captura de pantalla 2021-11-22 a las 13 18 27

@dasanra dasanra requested a review from DaniSomoza November 22, 2021 12:53
Copy link
Contributor

@DaniSomoza DaniSomoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! :D

@dasanra dasanra merged commit 04fb1a4 into main Nov 22, 2021
@dasanra dasanra deleted the restore-pr-review-and-prod-hook branch November 22, 2021 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants