Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@matextrem
Copy link
Contributor

What it solves

This PR closes #2429

How this PR fixes it

We added stepIndex property used in FullParagraph as a Transient prop

How to test it

  1. Go to create a Safe
  2. Navigate through the steps and you won't see any error in console related to stepIndex prop.

@matextrem matextrem added the Bug 🐛 Something isn't working label Jun 11, 2021
@matextrem matextrem self-assigned this Jun 11, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

@github-actions
Copy link

@katspaugh
Copy link
Member

katspaugh commented Jun 11, 2021

I've tested it and the warning is gone ✅
Thanks Mati!

@katspaugh katspaugh merged commit e644183 into development Jun 11, 2021
@katspaugh katspaugh deleted the bugfix/transient-stepIndex branch June 11, 2021 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A warning about stepIndex is shown in the console

3 participants