Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Nov 23, 2021

What it solves

There were some legacy information in .env.example and README that was causing confusion to some devs trying to run the interface

How this PR fixes it

It updates the docs to be aligned with latest changes for unified version

@dasanra dasanra requested a review from katspaugh November 23, 2021 15:17
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1495407728

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.878%

Totals Coverage Status
Change from base Build 1495261950: 0.0%
Covered Lines: 2983
Relevant Lines: 8353

💛 - Coveralls

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1495443523

Failed tests:

  • ❌ Safe Apps List Safe Apps List

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @dasanra!

@dasanra dasanra merged commit f526040 into dev Nov 23, 2021
@dasanra dasanra deleted the remove-deprecated-env-params-example branch November 23, 2021 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants