Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@iamacook
Copy link
Contributor

What it solves

Resolves #3202

How this PR fixes it

When out of order nonced, grouped transactions move from 'queued' to 'next', all 'next' transactions are added under said nonce.

How to test it

  1. Create a 'next' transaction but do not execute it.
  2. Create several transactions in the 'queue' with the same nonce.
  3. Execute the 'next' transaction and observe all 'queue' transactions shift to 'next', remaining in a group.

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@iamacook iamacook changed the title fix: Append further grouped, next txs Move all grouped transactions from next to queue Dec 22, 2021
@iamacook iamacook requested a review from katspaugh December 22, 2021 14:33
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if a tx is grouped but still expects an action from you (therefore is in next)?
Still works?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1611736007

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 32.187%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/logic/safe/store/reducer/gatewayTransactions.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 1610904042: -0.01%
Covered Lines: 3080
Relevant Lines: 8498

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1611763785

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review

@francovenica
Copy link
Contributor

Works fine for me

Created several tx with nonce+1 and left it in queue. I also rejected it so the rejection shows in parallel as well
Executed the tx with the current nonce
After execution all the tx in parallel still show in the queue tab.

@iamacook iamacook merged commit 1e147cf into dev Dec 22, 2021
@iamacook iamacook deleted the out-of-order-txs-disappearing branch December 22, 2021 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deep Link - Out of order parallel txs are dissapearing

5 participants