Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@iamacook
Copy link
Contributor

@iamacook iamacook commented Dec 22, 2021

What it solves

Resolves #3204

How this PR fixes it

Queued transactions were sometimes lacking a label and ythere was no distinguishment between queued.next and queued.queued. All unlabelled transactions were being deemed as queued.next, therefore showing the confirmation buttons.

Successfully labeled transactions then prevented due to the txQueuedTag conditional polling. Queued transactions are now manually requested if the deeplink inconsistency is present: a queued.next transaction does not exist, but a queued.queued does.

Note: deeplink slug names were also clarified as safeTxHash within the project and regex matching was included.

How to test it

  1. Create a queued transaction.
  2. Create a second queued transaction.
  3. The second should have a disabled confirm button.
  4. Navigating back to the queued list, both queued transactions should load.

Screenshots

image

@iamacook iamacook marked this pull request as draft December 22, 2021 16:30
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 22, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@coveralls
Copy link

coveralls commented Dec 22, 2021

Pull Request Test Coverage Report for Build 1614858735

  • 5 of 15 (33.33%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 32.189%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/safe/components/Transactions/TxList/TxSingularDetails.tsx 0 2 0.0%
src/logic/safe/store/reducer/gatewayTransactions.ts 0 3 0.0%
src/routes/safe/components/Transactions/TxList/hooks/useQueueTransactions.ts 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
src/routes/safe/components/Transactions/TxList/TxSingularDetails.tsx 1 1.79%
Totals Coverage Status
Change from base Build 1612048072: -0.006%
Covered Lines: 3083
Relevant Lines: 8510

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Dec 22, 2021

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1612353225

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review

@iamacook iamacook requested a review from katspaugh December 22, 2021 17:17
@iamacook iamacook marked this pull request as ready for review December 22, 2021 17:17
@katspaugh katspaugh changed the title Deeplink nonce order Fix: deeplink nonce order Dec 23, 2021
@katspaugh katspaugh merged commit 586d844 into dev Dec 23, 2021
@katspaugh katspaugh deleted the deeplink-nonce-order branch December 23, 2021 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deeplinked, out of nonce order transactions allow confirmation

4 participants