-
Notifications
You must be signed in to change notification settings - Fork 360
fix: remove letterSpacing
#3670
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1981763039
💛 - Coveralls |
katspaugh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
usame-algan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The letter-spacing already existed before but the fontSize changed from 14px to 16px with the redesign. I think removing the letter-spacing is a good solution to this. 👍
Interesting. Was there a specific reason for increasing the font size? Did you use SRC's input styles as a reference? |
It was defined as 16px in the style guide |
I see. Seeing as SRC doesn't have @yagopv, did you align with the style guide when creating the outlined components in SRC? |
Hey!! I didn't set the fontSize in the library. I left the default for material ui which is In the material default theme is set to 16px and if not, the default browsers font-size is 16px as well So shouldn't be an issue unless you are changing it explicitly |



What it solves
Resolves #3664
How this PR fixes it
The
letterSpacinghas been removed.How to test it
Observe non-truncated addresses in address input fields.
Screenshots