Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@iamacook
Copy link
Contributor

@iamacook iamacook commented Mar 14, 2022

What it solves

Resolves #3664

How this PR fixes it

The letterSpacing has been removed.

How to test it

Observe non-truncated addresses in address input fields.

Screenshots

image

@iamacook iamacook requested a review from usame-algan March 14, 2022 16:15
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1981763039

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 34.854%

Totals Coverage Status
Change from base Build 1980904960: 0.0%
Covered Lines: 3375
Relevant Lines: 8774

💛 - Coveralls

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The letter-spacing already existed before but the fontSize changed from 14px to 16px with the redesign. I think removing the letter-spacing is a good solution to this. 👍

@iamacook
Copy link
Contributor Author

The letter-spacing already existed before but the fontSize changed from 14px to 16px with the redesign. I think removing the letter-spacing is a good solution to this. 👍

Interesting. Was there a specific reason for increasing the font size? Did you use SRC's input styles as a reference?

@francovenica
Copy link
Contributor

Looks fine. the only case where it still doesn't show the full length is in the add safe workflow because of the check mark, but I think is a minor thing
image

I'd pass this ticket

@usame-algan
Copy link
Contributor

Interesting. Was there a specific reason for increasing the font size? Did you use SRC's input styles as a reference?

It was defined as 16px in the style guide

@iamacook
Copy link
Contributor Author

Interesting. Was there a specific reason for increasing the font size? Did you use SRC's input styles as a reference?

It was defined as 16px in the style guide

I see. Seeing as SRC doesn't have letterSpacing then I feel fine about this decision as well.

@yagopv, did you align with the style guide when creating the outlined components in SRC?

@yagopv
Copy link
Member

yagopv commented Mar 15, 2022

@yagopv, did you align with the style guide when creating the outlined components in SRC?

Hey!! I didn't set the fontSize in the library. I left the default for material ui which is 1rem so defaults to the html/body one (screenshot from current tx-builder inputs)

image

In the material default theme is set to 16px and if not, the default browsers font-size is 16px as well

image

So shouldn't be an issue unless you are changing it explicitly

@iamacook iamacook merged commit 650186d into dev Mar 15, 2022
@iamacook iamacook deleted the remove-input-letterspacing branch March 15, 2022 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The safe address is not seen fully on add safe form in safe field

7 participants