Skip to content

polish page and properties #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2023
Merged

polish page and properties #103

merged 4 commits into from
Feb 2, 2023

Conversation

@johguentner
Copy link
Member

@johguentner johguentner commented Feb 2, 2023

  • add parent information to page
  • check end-date of Date property for null
  • add "asText" method to Text and Title property

johguentner and others added 2 commits February 2, 2023 15:00
@johguentner
polish page and properties
de705ae 
- add parent information to page
- check end-date of Date property for null
- add "asText" method to Text and Title property
@mechelon
Apply fixes from StyleCI (#102)
8542f79
@johguentner johguentner added this to the 🌳 v1.0.0 milestone Feb 2, 2023
@what-the-diff
Copy link

what-the-diff bot commented Feb 2, 2023

  • Added parentId and parentType to Page entity
  • Fixed bug in Date property where end date was not being set if it is null (e.g., for a single day event)
  • Added asText() method to Text and Title properties, which returns the plain text version of the content instead of RichText object

@johguentner johguentner self-assigned this Feb 2, 2023
@johguentner johguentner added tests-required Tests for this PR are required enhancement New feature or request fix labels Feb 2, 2023
@johguentner
Merge branch 'dev' into page-and-property-polish
cbabe91
@johguentner
add tests which check properties/methods
ef0daae 
- of page parent information
- of Title and Text property (added: asText())
@johguentner johguentner removed the tests-required Tests for this PR are required label Feb 2, 2023
@johguentner johguentner merged commit 0ab4d2f into dev Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@johguentner johguentner

Labels

enhancement New feature or request fix

Projects

None yet

Milestone

🌳 v1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@johguentner @mechelon