Skip to content

Prevent Serialization of Scalar Values #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2023
Merged

Prevent Serialization of Scalar Values #143

merged 3 commits into from
Jun 9, 2023

Conversation

@johguentner
Copy link
Member

@johguentner johguentner commented Apr 30, 2023 •
edited
Loading

fix provided by @richardhj, which prevents serialization of scalar values
✅ tests added within page property tests

@what-the-diff
Copy link

what-the-diff bot commented Apr 30, 2023

PR Summary

  • Improved asText() method functionality
    Added a new condition to handle different content types more efficiently.

@johguentner johguentner requested a review from mechelon April 30, 2023 13:50
@johguentner johguentner added this to the 🍵 v1.1.0 milestone Apr 30, 2023
@johguentner johguentner self-assigned this Apr 30, 2023
@johguentner johguentner changed the title Fix/as text for scalar values Prevent Serialization of Scalar Values Apr 30, 2023
@johguentner johguentner merged commit ca767a0 into dev Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mechelon mechelon mechelon approved these changes

Assignees

@johguentner johguentner

Labels

fix

Projects

None yet

Milestone

🍵 v1.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@johguentner @mechelon @richardhj