implement notion block types as classes #19

johguentner · 2021-06-26T21:14:24Z

add easy content and text access for rich-text- (all supported blocks, exept page-blocks) and child-page-blocks
add fromResponse- and mapTypeToClass-method to Block::class (similar to the implementations within Property::class)

- add easy content and text access for rich-text- (all supported blocks, exept page-blocks) and child-page-blocks - add fromResponse- and mapTypeToClass-method to Block::class (similar to the implementations within Property::class)

check if correct instance is added to collection (depending on block type) check if content of blocks is correctly retreived

mechelon · 2021-06-27T12:23:28Z

src/Entities/Blocks/Block.php

+                $class = str_replace('_', '', ucwords($type, '_'));
+                return "FiveamCode\\LaravelNotionApi\\Entities\\Blocks\\" . $class;
+            case 'heading_1':
+                return "FiveamCode\\LaravelNotionApi\\Entities\\Blocks\\HeadingOne";


HeadingOne::class

mechelon · 2021-06-27T12:25:17Z

src/Entities/Collections/BlockCollection.php

 {
+    private bool $showUnsupported = false;
+
+    public function withUnsupported(): BlockCollection


TODO-Di: Add PhpDoc

mechelon · 2021-06-27T12:26:34Z

src/Entities/Collections/BlockCollection.php

+            return $collection;
+        } else {
+            return $collection->filter(function($block){
+                return $block->getType() != 'unsupported';


Maybe !== here

mechelon · 2021-06-27T12:26:42Z

src/Entities/Collections/BlockCollection.php

+
+    public function asCollection(): Collection
+    {
+        $collection =parent::asCollection();


mechelon · 2021-06-27T12:27:47Z

src/Entities/Collections/EntityCollection.php

    public function asJson(): string
    {
-        return $this->collection->map(function (Entity $item) {
+        return $this->asCollection()->map(function (Entity $item) {


Document this in the Changelog, it's not really breaking but somehow... changed 🤔

mechelon · 2021-07-19T13:43:17Z

tests/EndpointBlocksTest.php

+         Http::fake([
+             'https://api.notion.com/v1/blocks/1d719dd1-563b-4387-b74f-20da92b827fb/children*'
+             => Http::response(
+                 json_decode(file_get_contents('tests/stubs/endpoints/blocks/response_specific_supported_blocks_200.json'), true),


check indentation to be sure

- for HeadingOne, HeadingTwo and HeadingThree

johguentner

applied all necessary changes

johguentner · 2021-08-21T18:40:25Z

src/Entities/Blocks/Block.php

+                $class = str_replace('_', '', ucwords($type, '_'));
+                return "FiveamCode\\LaravelNotionApi\\Entities\\Blocks\\" . $class;
+            case 'heading_1':
+                return "FiveamCode\\LaravelNotionApi\\Entities\\Blocks\\HeadingOne";


johguentner · 2021-08-21T18:40:36Z

src/Entities/Collections/BlockCollection.php

 {
+    private bool $showUnsupported = false;
+
+    public function withUnsupported(): BlockCollection


johguentner · 2021-08-21T18:41:00Z

src/Entities/Collections/BlockCollection.php

+
+    public function asCollection(): Collection
+    {
+        $collection =parent::asCollection();


johguentner · 2021-08-21T18:41:19Z

src/Entities/Collections/BlockCollection.php

+            return $collection;
+        } else {
+            return $collection->filter(function($block){
+                return $block->getType() != 'unsupported';


johguentner

checked

implement notion block types as classes

f4ca7a4

- add easy content and text access for rich-text- (all supported blocks, exept page-blocks) and child-page-blocks - add fromResponse- and mapTypeToClass-method to Block::class (similar to the implementations within Property::class)

johguentner requested a review from mechelon June 26, 2021 21:14

implemented tests for blocks-endpoint

f9e1947

check if correct instance is added to collection (depending on block type) check if content of blocks is correctly retreived

mechelon requested changes Aug 21, 2021

View reviewed changes

johguentner added 3 commits August 21, 2021 20:34

direct reference to class within mapTypeToClass

5e00647

- for HeadingOne, HeadingTwo and HeadingThree

add phpdocs for the BlockCollection

ad5a130

small tweak

062e07d

johguentner commented Aug 21, 2021

View reviewed changes

johguentner merged commit 367cd32 into dev Aug 21, 2021

mechelon deleted the feature/blocks branch June 17, 2022 15:43

Uh oh!

implement notion block types as classes #19

implement notion block types as classes #19

Uh oh!

Conversation

johguentner commented Jun 26, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johguentner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johguentner left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants