Skip to content

add url to page #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2021
Merged

add url to page #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
539b599
add url to page
johguentner Jul 18, 2021
27f61a6
rename 'fillUrl' to 'fillPageUrl'
johguentner Aug 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/Entities/Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ class Page extends Entity
*/
protected string $title = '';

/**
* @var string
*/
protected string $url = '';

/**
* @var string
*/
Expand Down Expand Up @@ -101,6 +106,7 @@ private function fillFromRaw(): void
$this->fillObjectType();
$this->fillProperties();
$this->fillTitle(); // This has to be called after fillProperties(), since title is provided by properties
$this->fillPageUrl();
$this->fillCreatedTime();
$this->fillLastEditedTime();
}
Expand Down Expand Up @@ -151,6 +157,16 @@ private function fillTitle(): void
}
}

/**
*
*/
private function fillPageUrl(): void
{
if (Arr::exists($this->responseData, 'url')) {
$this->url = $this->responseData['url'];
Copy link
Member

@mechelon mechelon Jul 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to pageUrl? because this is not a property 🤔

Copy link
Member Author

@johguentner johguentner Aug 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅😊 done

}
}

/**
* @param $propertyTitle
* @param $property
Expand Down Expand Up @@ -324,6 +340,14 @@ public function getTitle(): string
return $this->title;
}

/**
* @return string
*/
public function getUrl(): string
{
return $this->url;
}

/**
* @return Collection
*/
Expand Down