block creation + all new current blocks (+ tests for creation/fetch) #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johguentner
commented
Sep 11, 2021
johguentner
commented
- implemented static creation-function for all modifiable blocks
- implemented append-function to Block-Endpoint
- implemented tests-function, in which all block-creation-functions are tested
- added todo/warning for notion-version-change to test-function
- implemented static creation-function for all modifiable blocks - implemented append-function to Block-Endpoint - implemented tests-function, in which all block-creation-functions are tested - added todo/warning for notion-version-change to test-function
- rename "fillContent" of Block to "fillRawContent", since it is filling the rawContent (no direct breaking change) - added EmbedBlock (retreive url + caption)
- this ensures the currect values within the class attributes
- this ensures the correct values within the textblock classes attributes
- set up BaseFileBlock::class for file-related blocks (file, image, file, pdf) - implement Modifiable within embed and BaseFileBlock - mark caption as optional paramter in embed and BaseFileBlock with empty string as default - set up tests for all new blocks (creation and retreival)
Feature/new blocks
Member
Author
|
Add new blocks + some polish (non-breaking) within Block-Entity (base for all blocks) + tests for all new blocks (creation + retreival) polish method name in Block + add Embed-Block
set up BaseFileBlock::class for file-related blocks (file, image, file, pdf)
|
johguentner
changed the title
johguentner
changed the title
mechelon
requested changes
Sep 13, 2021
Member
|
This has nothing to do with this release, but we could use this for better structure: |
- rename "BaseBlockEntity" to "BlockEntity" in BlockEndpoint for clearity - mark createFileBlock method in BaseFileBlock as final - replace array_push with array[] = [...] for better performance
polish implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.