feat(stacktrace): Show entire stacktrace#67
Merged
Conversation
I find the current stack-trace, whilst simple, does not have enough information for debugging an issue. Change this to show the entire stacktrace.
ikhemissi
approved these changes
Feb 7, 2022
Contributor
ikhemissi
left a comment
ikhemissi
left a comment
There was a problem hiding this comment.
LGTM
More stack trace lines would definitely be more helpful 👍
I think we should not remove third party library (e.g. node_modules/*) entries in the stacktrace as they can add more explanation for why an error happened especially if the error is a bit vague.
5app-Machine
added a commit
that referenced
this pull request
Feb 7, 2022
# [2.3.0](v2.2.0...v2.3.0) (2022-02-07) ### Features * **stacktrace:** Show entire stacktrace ([#67](#67)) ([11564b2](11564b2))
Contributor
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
I find the current stack-trace, whilst simple, does not have enough information for debugging an issue.
i.e. I do not know where this Error was called
{ "content": { "service": "app", "message": "themepark: could not load https://frontend-cdn.5app.com/public/themepark/production/style.json", "attributes": { "stacktrace": [ "at Request.<anonymous> (/home/node/app/node_modules/got/dist/source/as-promise/index.js:117:42)", "at runMicrotasks (<anonymous>)" ], "tag": "d5370b1", "error": "Response code 404 (Not Found)", "timestamp": "2022-02-07T11:20:26.416Z", "level": "error" } } }For consideration:...
We could filter out the lines with
node_modulesas debugging a third party is not as preferable to knowing where in our code we called that third party IMO.