feat(2024): Add 2024 ability scores and skills tables #815
Conversation
bagelbits
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the 2024 Ability Scores table based on SRD v5.2, updates the database refresh script to load the new 2024 tables, and adds corresponding tests for data integrity.
- Adds tests in src/2024/tests to validate duplicate indices and API references.
- Updates dbRefresh.ts to include uploading for 2024 tables.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/2024/tests/tables.test.js | Introduces tests for duplicate indices and API references using JSON entries. |
| scripts/dbRefresh.ts | Adds functionality to upload 2024 tables from the designated folder. |
Files not reviewed (1)
- src/2024/5e-SRD-Ability-Scores.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bagelbits
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for 2024 ability scores and skills tables based on SRD v5.2, updates the database refresh script to import the new 2024 tables, and includes tests to verify the uniqueness of indices and the integrity of API references.
- Adds tests in src/2024/tests/tables.test.js to catch duplicate indices and broken API links.
- Updates scripts/dbRefresh.ts to upload 2024 tables alongside the existing 2014 tables.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/2024/tests/tables.test.js | Introduces tests for detecting duplicate indices and validating API references in 2024 JSON data files. |
| scripts/dbRefresh.ts | Adds a call to upload 2024 tables in the database refresh process. |
Files not reviewed (2)
- src/2024/5e-SRD-Ability-Scores.json: Language not supported
- src/2024/5e-SRD-Skills.json: Language not supported
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this do?
dbRefresh.tsto pull in 2024 tables (necessary for docker images)How was it tested?
Ran tests and linter locally
Here's a fun image for your troubles