Skip to content

Commit 1c9289d

Browse files
committed
Bug 967888 - Minor visual bugs in settings fxa panels
1 parent dc16451 commit 1c9289d

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

apps/settings/elements/firefox_accounts.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ <h1 data-l10n-id="fxa-accounts"> Firefox Accounts </h1>
1717
</li>
1818
<li>
1919
<label>
20-
<button id="fxa-login">
20+
<button class="recommend" id="fxa-login">
2121
<span data-l10n-id="fxa-login">Create Account or Sign In</span>
2222
</button>
2323
</label>
@@ -31,7 +31,7 @@ <h2 data-l10n-id="fxa-confirm-account">Confirm Your Account</h2>
3131
<ul>
3232
<li>
3333
<p data-l10n-id="fxa-verification-email-sent" id="fxa-unverified-text" class="description">
34-
We've sent an email to: <em>foo@bar.com</em>
34+
We've sent an email to: <strong>foo@bar.com</strong>
3535
</p>
3636
<p data-l10n-id="fxa-please-confirm" class="description">
3737
Please confirm your account by clicking the link in your email.
@@ -50,10 +50,10 @@ <h2 data-l10n-id="fxa-myaccount"> My Account </h2>
5050
<li>
5151
<p data-l10n-id="fxa-description" class="description">
5252
Firefox lets you use a single account to log in to services like
53-
Marketplace and Where's my Fox.
53+
Marketplace and Where’s My Fox.
5454
</p>
5555
<p data-l10n-id="fxa-logged-in-text" id="fxa-logged-in-text" class="description">
56-
Logged in as <em>foo@bar.com</em>
56+
Logged in as <strong>foo@bar.com</strong>
5757
</p>
5858
</li>
5959
</ul>
@@ -63,10 +63,10 @@ <h2 data-l10n-id="fxa-registered-apps-header"> Registered Apps </h2>
6363
</header>
6464
<ul>
6565
<li>
66-
<span data-l10n-id="fxa-marketplace-app"> Marketplace </span>
66+
<span data-l10n-id="fxa-marketplace-app"><strong> Marketplace </strong></span>
6767
</li>
6868
<li>
69-
<span data-l10n-id="fxa-wheres-my-fox-app"> Where's my Fox </span>
69+
<span data-l10n-id="fxa-wheres-my-fox-app"><strong> Where’s My Fox </strong></span>
7070
</li>
7171
</ul>
7272

apps/settings/js/firefox_accounts.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,11 @@ var FxaMenu = (function fxa_menu() {
133133

134134
if (state == 'verified') {
135135
navigator.mozL10n.localize(menuDesc, 'fxa-logged-in-text', {
136-
email: Normalizer.escapeHTML(email)
136+
email: '<strong>' + Normalizer.escapeHTML(email) + '</strong>'
137137
});
138138
} else if (state == 'unverified') {
139139
navigator.mozL10n.localize(menuDesc, 'fxa-check-email', {
140-
email: Normalizer.escapeHTML(email)
140+
email: '<strong>' + Normalizer.escapeHTML(email) + '</strong>'
141141
});
142142
} else { // state == 'loggedout'
143143
navigator.mozL10n.localize(menuDesc, 'fxa-login');
@@ -241,8 +241,7 @@ var FxaPanel = (function fxa_panel() {
241241

242242
function showLoggedInPanel(email) {
243243
navigator.mozL10n.localize(loggedInEmail, 'fxa-logged-in-text', {
244-
// email: '<em>' + email + '</em>'
245-
email: email
244+
email: '<strong>' + email + '</strong>'
246245
});
247246
loggedInPanel.hidden = false;
248247
logoutBtn.onclick = _fxaModel.onLogoutClick;
@@ -256,8 +255,7 @@ var FxaPanel = (function fxa_panel() {
256255
function showUnverifiedPanel(email) {
257256
unverifiedPanel.hidden = false;
258257
navigator.mozL10n.localize(unverifiedEmail, 'fxa-verification-email-sent', {
259-
// email: '<em>' + email + '</em>'
260-
email: email
258+
email: '<strong>' + email + '</strong>'
261259
});
262260
}
263261

apps/settings/locales/settings.en-US.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ accounts=Account Management
624624
fxa-accounts=Firefox Accounts
625625

626626
# Panel: logged out
627-
fxa-description=Firefox lets you use a single account to log in to services like Marketplace and Where’s my Fox.
627+
fxa-description=Firefox lets you use a single account to log in to services like Marketplace and Where’s My Fox.
628628
fxa-login=Create Account or Sign In
629629

630630
# Panel: logged in, unverified

0 commit comments

Comments
 (0)