-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rowspan #381
Comments
In addition, I found this thread about it (from 2013): Where this fork is mentioned: However, I assume that code can't just be copy pasted without breaking existing functionality of this main branch. |
I think this is too specialised to be on our list of plans for the grid. There is a DetailsView plugin (see the examples) which merges several whole rows, but I think that's all you'll get. |
Thanks for the clarification. DetailsView only puts a div over several dynamically created empty rows below the clicked row, so no merging there either. |
Just want to let you know that this feature request would also be very helpful for my own application (I figure that maybe if you see a lot of users wanting this feature you might change your mind about implementing it; regardless, thanks for the great work you do!). |
to which I'll reply the same as this other comment shown below... This is an Open Source project, the best way to get it done is for you to contribute.
|
👍 I second that!
I had frozen columns, but I do not recall from memory if that feature was in the same branch. Might be it's only brought together in the specialized commercial work I did. My memory is fading... Just couple of notes on all this:
Sorry, got onto a bit of a soapbox rant there. It's still vivid after all these years. 😄 I hope to be able to revisit SlickGrid one day and see if some of my own doodads are still useful or need redoing another way then, but don't bet on that happening anytime in your lifetime. 😉 To close on a happy and positive note: I was able to pull it off, with the great help of other SlickGrid forks and people. So you can too!
The truly tough part is keeping at it for a decade, which is why I have great respect for @6pac, @ghiscoding and the others that are still around and active! 👍👍👍 |
In case you wonder about MS Excel (which would be considered The Reference for this sort of thing): it has nasty behavioural quirks too. And that's Excel 2019 we're talking about! Watch the vid where I move around and (try to) edit a merged cell. Notice that Excel splits the cell and does an (awkward) double render of the thing, live-updating the second copy while the edited cell is clipped to the frozen rectangle area. Not nice, pretty confusing. Not having these or other weird artifacts would mean SlickGrid would do it better than MS Excel (and thus the MS dev team). Also note their scroll bug when I move from right to left into the frozen zone through the merged cell: watch column C not showing up and thus the merged cell render remaining clipped. I consider that a UI bug. (Which would be very similar to the problems SlickGrid and others would be facing with this, BTW.) Enjoy the vid of the keyboard walk in Excel: Excel.frozen.and.merged.cells.behaviour.mp4TL;DR: mixing frozen columns with merged cells is a... challenge! 😉 |
wow a reply coming directly from @GerHobbelt in person, it's really nice to hear from you. I loved all your huge set of examples and took a look at them multiple times, I admit that I also copied a lot of your code here & there to merge in here as well 😉 I agree that it's hard to keep an Open Source project active for so many years, thanks to @6pac for sticking around for so long and helping with this fork for so many years. We use it at work which is why I contributed, in here and in my multiple SlickGrid wrapper libs, so many new features and bug fixes. I often say/think that if you really want a bug to be fixed, then work on a fix yourself... I'm doing soap opera too, lol I just wish more people would contribute sometime... 😄. On the subject of row span with frozen feature, it is indeed a complexity to the highest level, dealing with 2 separate divs (which is how the frozen feature works) is making it hard to keep in sync and it brings some unresolved issues, take this one for example #443 😨 |
Whoa, looks like the issue is a lot more complicated than I thought. I'll just say thank you to all you guys for creating/maintaining such a wonderful open source project! |
LOL. Hi @GerHobbelt, great to know you're still out there keeping an eye on things! It's truly a team effort. @ghiscoding is far more active than me these days. Perhaps some day the pendulum will swing again. Even better, perhaps we'll get even more enthusiastic contributors! Great to see the rant - some great points in there. At some point we need to put together a matrix of which features work with each other. One thing I haven't discussed with @ghiscoding yet, but have been meaning to, is the idea of creating a virtual canvas object. That is, a js object that hides all the split-canvas functionality and makes it look like the grid is dealing with the original single canvas. Then we could lock a rowspan feature like the OP is talking about to single-canvas mode. This would be almost as much work as the original frozen panes feature, but I feel like it's probably the best long term road forwards. I haven't yet build a proof of concept to see if it's actually feasible, but I suspect it will be. |
I would really like to have rowspan to span the first cell of one row over multiple rows, it seems like this is not supported at the moment or am I missing something? If not, are there any plans to have this implemented?
The text was updated successfully, but these errors were encountered: