Add security module to membersuite_api_client #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rerb
commented
Feb 4, 2017
rerb
commented
- models.py defines PortalUser.
- services.py defines LoginToPortalError and login_to_portal().
For 2 reasons. 1. I've got a use case where I want to use convert_ms_object() but I don't have a ConciergeClient. So make it a class method? Well, I thought of that, but ... 2. convert_ms_object() doesn't do anything with its first argument whether it's `self` or `cls` so it can really stand alone, separate from ConciergeClient. Hence new home in utils.
Renamed to `get_session_id` and moved to utils module.
* models.py defines PortalUser. * services.py defines LoginToPortalError and login_to_portal().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.