Organizations and Memberships #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added memberships submodule. Created MembershipService and associated methods. Created initial Membership model, will expand after tests are created and I can see exactly what's in the objects returned from MemberSuite.
Working version of memberships models and methods. Test passing. Needs to figure out a sane test for get_all_memberships() that doesn't require pulling all 942+ memberships (a number that will change once data goes live). May have to wait until we have a sandbox created that has unchanging data. @todo - Add tests for membership products.
Fixed MembershipProducts model and related methods in services. Added tests for that, and figured out a test for the get_all_memberships() method.
Removed rogue file where I was dumping a test object from a MS response. Added iniitial org stuff before I noticed that.
Added parameters limit_to, depth, and max_depth to get_all_memberships(). This allows tests to specify 1 result per iteration, and limit the number of iterations. Depth tracks the current iteration count. Added a check to compare depth to max_depth to decide if it should recur again.
Added test to make sure we're getting proper Membership objects. Required modifying get_all_memberships() to call the package method before concatenation...if it was called in the return statement as usual it broke due to recursion (tried packaging parts of the results that were already converted).
Added Organization Service and associated tests. Just need to flesh out Organization model more and we're done!
Apparently the possible organization types have changed since last I worked on this. As such, decided to abstract that to a metadata class of its own rather than doing a local dict matching. Expanded Organization attributes to match what is needed in the ISS.
Our other tests call this incidentally because we're constantly converting objects and pulling session IDs.
Contributor
Author
|
Some login tests are failing on earlier versions of django, but that's also true in the master branch at the moment. Unless you guys see something weird, I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported organization stuff over to this branch as well to avoid complicated merge sequences.