Skip to content

Fix and Test Flatmap API Server Error #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 29, 2025
Merged

Fix and Test Flatmap API Server Error #315

merged 9 commits into from
Oct 29, 2025

Conversation

@akhuoa
Copy link
Member

@akhuoa akhuoa commented Oct 19, 2025

Component changes

  • Split 404 error into http-level and application-level
  • Add error handling for 500 with valid data in response (goes to general error handling)

Tests

  • Add tests for flatmap API errors (500, 500 with valid data, 404, and Network error)

@akhuoa akhuoa requested a review from alan-wu October 19, 2025 23:52
alan-wu
alan-wu approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@alan-wu alan-wu merged commit 85c8896 into ABI-Software:main Oct 29, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alan-wu alan-wu alan-wu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akhuoa @alan-wu