Add borderStyle property, defaulting to default if not set. #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-wu
reviewed
Nov 17, 2025
| const specifiedColour = this.item["color"] ? this.item["color"] : this.item["colour"]; | ||
| let colour = specifiedColour ? specifiedColour : "transparent"; | ||
| let borderColour = this.item.border ? this.item.border : "black"; | ||
| let borderStyle = this.item.borderStyle ? this.item.borderStyle : "solid"; |
Member
There was a problem hiding this comment.
This is messing up the style of few other legends. It should fall back to default instead of solid.
alan-wu
requested changes
Nov 17, 2025
Member
alan-wu
left a comment
alan-wu
left a comment
There was a problem hiding this comment.
Some legends are not correct with the border set to solid.
alan-wu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for issue #319
The related PR is:
AnatomicMaps/flatmap-viewer#70