Black Hole Tank not dropping buckets #848
lamechimpala
started this conversation in
Bugfix Suggestions
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Discovered on DJ2, if you fill your inventory with buckets of a liquid (e.g., liquid starlight), it will not drop these buckets onto the ground when your inventory is full, and seemingly disappears.
WaitingIdly noticed that the
playerIn.addItemStackToInventory(result.result);
line should perform as
if (!playerIn.addItemStackToInventory(result.result)) playerIn.dropItem(itemstack1, false); instead.
Easy to reproduce; fill a BHT with a large quantity of liquid, take out an inventories worth of buckets and continue to fill buckets, and observe no buckets dropping, nor auto locating to an alternate inventory (e.g., AE2, chests, handy bag, dank null).
https://github.com/InnovativeOnlineIndustries/Industrial-Foregoing/blob/1.12/src/main/java/com/buuz135/industrial/tile/block/BlackHoleTankBlock.java#L146
Beta Was this translation helpful? Give feedback.
All reactions