Skip to content

Fix issues in sample_timeit #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

Fix issues in sample_timeit #24

merged 1 commit into from
Aug 28, 2025

Conversation

@hylin2002
Copy link
Collaborator

@hylin2002 hylin2002 commented Aug 28, 2025

In the previous PR, simple_timeit will have issue when there is no matrix_dim argument as input, and this issue is fixed in this PR.

The detailed changes are:

  • Set a default value matrix_dim=None in simple_timeit and timeit_from_trace.
  • Assign different trace_name according to the value of matrix_dim.

@hylin2002 hylin2002 requested a review from chishuen August 28, 2025 05:07
chishuen
chishuen approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@chishuen chishuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hylin2002 hylin2002 force-pushed the add-trace_dir-suffix branch from 778066a to b99016c Compare August 28, 2025 05:20
@hylin2002 hylin2002 merged commit 4295384 into AI-Hypercomputer:main Aug 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chishuen chishuen chishuen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hylin2002 @chishuen