Skip to content

Fix metrics query #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Fix metrics query #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2c0ff0
Fix metrics query
jjk-g Mar 21, 2025
4fb3f55
PR feedback
jjk-g Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions benchmark_serving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,14 +728,22 @@ def print_metrics(metrics: List[str], duration: float, namespace: str, job: str)
# handle response
if request_post.ok:
if response["status"] == "success" and response["data"] and response["data"]["result"]:
metric_results[query_name] = float(response["data"]["result"][0]["value"][1])
logger.debug("%s: %s" % (query_name, response["data"]["result"][0]["value"][1]))
r = response["data"]["result"]
if not r:
logger.debug(f"Failed to get result for {query_name}")
continue
v = r[0].get("value", None)
if not v:
logger.debug(f"Failed to get value for result: {r}")
continue
metric_results[query_name] = float(v[1])
logger.debug("%s: %s" % (query_name, v[1]))
else:
logger.debug("Cloud Monitoring PromQL Error: %s" % (response))
return server_metrics
continue
else:
logger.debug("HTTP Error: %s" % (response))
return server_metrics
continue
server_metrics[metric] = metric_results
return server_metrics

Expand Down