Update run_interactive.py with finer control of profiler. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsy323
approved these changes
May 24, 2024
FanhaiLu1
approved these changes
May 24, 2024
lsy323
reviewed
May 24, 2024
|
|
||
| profiling_output = FLAGS.profiling_output | ||
| if profiling_output: | ||
| profiling_prefill = FLAGS.profiling_prefill |
Collaborator
There was a problem hiding this comment.
Current logic only handles:
- profile both output and prefill
- profile output but not prefill
If profile prefill but not output, the current logic won't profile at all. Not sure if we want to handle this case as well. We can add in future PR if there is such use case as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.