Skip to content

Metrics bug: server_lib should be config_lib #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Metrics bug: server_lib should be config_lib #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f95a83
Metrics bug: server_lib should be config_lib
Bslabe123 Jun 3, 2024
239b0ab
format
Bslabe123 Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions run_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import jetstream_pt
from absl import app, flags
from jetstream.core import server_lib
from jetstream.core.config_lib import ServerConfig
from jetstream.core.config_lib import ServerConfig, MetricsServerConfig
from jetstream_pt.config import FLAGS, create_engine_from_config_flags

flags.DEFINE_integer("port", 9000, "port to listen on")
Expand Down Expand Up @@ -49,11 +49,9 @@ def main(argv: Sequence[str]):
)
print(f"server_config: {server_config}")

metrics_server_config: server_lib.MetricsServerConfig | None = None
metrics_server_config: MetricsServerConfig | None = None
if FLAGS.prometheus_port != 0:
metrics_server_config = server_lib.MetricsServerConfig(
port=FLAGS.prometheus_port
)
metrics_server_config = MetricsServerConfig(port=FLAGS.prometheus_port)

# We separate credential from run so that we can unit test it with local credentials.
# We would like to add grpc credentials for OSS.
Expand Down