Skip to content

Add server tests #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2024
Merged

Add server tests #142

merged 4 commits into from
Jul 8, 2024

Conversation

@bvrockwell
Copy link
Contributor

creates unit tests for run_server.py

Tests to provide some coverage to important launch scripts, with a focus on default configuration instantiation.

  1. test sets different model_name params to instantiate default configs. Provides some coverage for unintended default changes.
  2. this test ensures the server run and wait for termination methods are called exactly once.

@bvrockwell bvrockwell marked this pull request as ready for review July 5, 2024 03:41
@bvrockwell bvrockwell requested a review from FanhaiLu1 July 5, 2024 03:41
@qihqi qihqi merged commit 98a8e28 into main Jul 8, 2024
@qihqi qihqi deleted the add-server-tests branch July 8, 2024 17:12
@qihqi
Copy link
Collaborator

qihqi commented Jul 8, 2024

thanks!

FanhaiLu1
FanhaiLu1 reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@FanhaiLu1 FanhaiLu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

wang2yn84 pushed a commit that referenced this pull request Jul 18, 2024
@bvrockwell @wang2yn84
Add server tests (#142)
e4dac2e 
* add enable jax profiler to run_server

* add run_server.py unit tests

* add ring buffer test
@FanhaiLu1 FanhaiLu1 mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FanhaiLu1 FanhaiLu1 FanhaiLu1 left review comments

@qihqi qihqi qihqi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bvrockwell @qihqi @FanhaiLu1