Skip to content

fix ray engine crashes on multihost #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix ray engine crashes on multihost #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions jetstream_pt/ray_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,6 @@ def prefill_ray(
logits = logits[0]

token = np.argmax(logits[true_length - 1])
updated_caches = multihost_utils.process_allgather(
updated_caches, tiled=True
)
prefix = Prefix(token, updated_caches, true_length)
self.prefix_queue.put(prefix, block=False)

Expand All @@ -490,7 +487,7 @@ def prefill_ray(
samples_per_slot=1,
)

return prefix, result
return None, result

def _convert_to_np_caches(
self, caches: List[Tuple[jax.Array, jax.Array]]
Expand Down