Skip to content

Add gemma support in better cli #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 30, 2024
Merged

Add gemma support in better cli #176

merged 5 commits into from
Aug 30, 2024

Conversation

@qihqi
Copy link
Collaborator

@qihqi qihqi commented Aug 29, 2024 •
edited
Loading 

python -m jetstream_pt.cli interactive --model_id meta-llama/Meta-Llama-3-8B-Instruct --quantize_weights=0

@qihqi qihqi requested review from FanhaiLu1 and lsy323 and removed request for FanhaiLu1 August 29, 2024 23:11
@qihqi qihqi marked this pull request as ready for review August 29, 2024 23:11
qihqi added 5 commits August 30, 2024 00:37
@qihqi
Add gemma support in better cli
15abcb2
@qihqi
checkpoint on converting cli
b20bc5c 
* llama 2 works
* gemma works
* llama 3 sometimes produces no output
* mixtral not working yet
@qihqi
checkpoint
b59c542
@qihqi
mixtral working,
d72a6da 
gemma and llama also works
@qihqi
cosmetic fixes
15f4aa4
FanhaiLu1
FanhaiLu1 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@FanhaiLu1 FanhaiLu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much better than before

@qihqi qihqi merged commit 7cbd9ec into main Aug 30, 2024
@qihqi qihqi deleted the hanq_gemma_cli branch August 30, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FanhaiLu1 FanhaiLu1 FanhaiLu1 approved these changes

@lsy323 lsy323 Awaiting requested review from lsy323

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qihqi @FanhaiLu1