Skip to content

Pass metrics client config through to Jetstream #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2024
Merged

Pass metrics client config through to Jetstream #99

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21122e9
first commit
Bslabe123 May 22, 2024
b63a0bf
Merge branch 'main' into prometheus-port-flag
Bslabe123 May 23, 2024
c548a30
reformat
Bslabe123 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions run_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"InterleavedCPUTestServer",
"available servers",
)
flags.DEFINE_integer("prometheus_port", 0, "")


# pylint: disable-next=all
Expand All @@ -48,13 +49,20 @@ def main(argv: Sequence[str]):
)
print(f"server_config: {server_config}")

metrics_server_config: server_lib.MetricsServerConfig | None = None
if FLAGS.prometheus_port != 0:
metrics_server_config = server_lib.MetricsServerConfig(
port=FLAGS.prometheus_port
)

# We separate credential from run so that we can unit test it with local credentials.
# We would like to add grpc credentials for OSS.
jetstream_server = server_lib.run(
threads=FLAGS.threads,
port=FLAGS.port,
config=server_config,
devices=devices,
metrics_server_config=metrics_server_config,
)
print("Started jetstream_server....")
jetstream_server.wait_for_termination()
Expand Down