Skip to content

Conversation

@coolkp
Copy link
Collaborator

@coolkp coolkp commented Apr 24, 2025

  • Add option to save compilation timing metric and other timing metrics
  • Add to e2e script step time and flops assertion.
  • Add name to train partial.
  • Make cached_download conditional import. it prevents upgrading transformers and huggingface_hub . cached_download is removed and its alternative is already being used hf_hub_download in maxdiffusion , path exercising cached_download is in try and except block

Ran

  • python -m pytest
  • bash code_style.sh

coolkp added 2 commits April 24, 2025 21:56
…port of hugginface_hub and update huggingface hub

Signed-off-by: Kunjan patel <kunjanp@google.com>
Signed-off-by: Kunjan patel <kunjanp@google.com>
@coolkp coolkp requested a review from entrpn April 24, 2025 22:47
Signed-off-by: Kunjan patel <kunjanp@google.com>
@entrpn entrpn merged commit 69b8811 into main Apr 25, 2025
2 of 3 checks passed
coolkp added a commit that referenced this pull request Apr 28, 2025
* Add compilation metrics, parse step time in e2e, add name to train partial etc (#166)

* Add compilation metrics, script to assert metrics, add conditional import of hugginface_hub and update huggingface hub

Signed-off-by: Kunjan patel <kunjanp@google.com>

* Formatting

Signed-off-by: Kunjan patel <kunjanp@google.com>

* Fix pylint issues

Signed-off-by: Kunjan patel <kunjanp@google.com>

---------

Signed-off-by: Kunjan patel <kunjanp@google.com>

* Fix 413751357 updating version of depdendency which is lowering the JAX version (#167)

* Fix 413751357 updating orbax version which is lowering the JAX version

* Updating the right dependency

---------

Signed-off-by: Kunjan patel <kunjanp@google.com>
Co-authored-by: Param Bole <parambole@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants