-
Notifications
You must be signed in to change notification settings - Fork 433
Onboard GPT OSS model #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard GPT OSS model #2241
Conversation
8900a7b to
34457b6
Compare
f271f48 to
a5ef467
Compare
a5ef467 to
904091d
Compare
shuningjin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great work!
gagika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, if you agree, feel free to address them in a separate PR.
78a574a to
c710f50
Compare
c710f50 to
04b16f6
Compare
aireenmei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ran!
gagika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Onboard GPT OSS model:
Next step: we will work on ckpt conversion and verify logits
Tests
check_gpt_vs_reference.pyagainst reference implementation for attention & mlp blocksChecklist
Before submitting this PR, please make sure (put X in square brackets):