Treat additional error types as potential slice down issues. #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_802202196
branch
from
36323d1 to
6746182
Compare
This change separates the set of `JaxRuntimeError` types that are considered indicative of a slice being down into `DATA_LOSS` and additional types. `DEADLINE_EXCEEDED`, `NOT_FOUND`, and `INTERNAL` are now treated as "may or may not" be related to slice down but still returning true. PiperOrigin-RevId: 802205795
copybara-service
bot
force-pushed
the
test_802202196
branch
from
6746182 to
c88deea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat additional error types as potential slice down issues.
This change separates the set of
JaxRuntimeErrortypes that are considered indicative of a slice being down intoDATA_LOSSand additional types.DEADLINE_EXCEEDED,NOT_FOUND, andINTERNALare now treated as "may or may not" be related to slice down but still returning true.