Skip to content

Conversation

@DannyLiCom
Copy link
Collaborator

@DannyLiCom DannyLiCom commented Aug 12, 2025

Fixes / Features

  • Add credential test with DNS retry logic
  • Added a run_command_and_capture_output function to capture errors

Testing / Documentation

To verify this feature, run the standard xpk cluster create-pathways command. The new credential test with DNS retry logic will be executed as part of the cluster creation process.
https://screenshot.googleplex.com/cTjV7ABQr2omQZd

If a DNS endpoint-related error occurs, the following message will be displayed, followed by an automatic retry:
https://screenshot.googleplex.com/BunMupVA8Yp998o
However, because the --enable-dns-access flag is present by default, the error mentioned above will not appear.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

@DannyLiCom
Copy link
Collaborator Author

@SujeethJinesh Please review this PR. My current default for get-credentials is --dns-endpoint, because I see that the create cluster command also defaults to --enable-dns-access.

@DannyLiCom
Copy link
Collaborator Author

@scaliby I modified the if statements to reduce nesting. Please review it again.

Copy link
Collaborator

@SujeethJinesh SujeethJinesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just needed confirmation about --force-conflicts

@scaliby
Copy link
Member

scaliby commented Sep 3, 2025

@DannyLiCom any updates on this?

@DannyLiCom
Copy link
Collaborator Author

DannyLiCom commented Sep 4, 2025

@DannyLiCom any updates on this?

@scaliby The check below is showing the error "Kubernetes cluster can't find Job." I don't think this is related to my get_credential modifications, and I'm not sure what to change to fix it.
https://screenshot.googleplex.com/4Qs6co5Tv4FGku9

@DannyLiCom
Copy link
Collaborator Author

@jamOne- If there are no issues, can you help me merge it? It seems authorization is required to merge now.

@DannyLiCom
Copy link
Collaborator Author

@jamOne- The check is getting stuck at the verify goldens and appears to be blocked by a "No module named 'ruamel'" error.

@jamOne-
Copy link
Collaborator

jamOne- commented Oct 2, 2025

ruamel is one of our dependencies, please install them with pip install -e .

@DannyLiCom
Copy link
Collaborator Author

@jamOne- Please review it again! Thanks!

@jamOne- jamOne- merged commit 4e2543e into develop Oct 2, 2025
12 checks passed
@jamOne- jamOne- deleted the lidanny/feature/check_dns_access branch October 2, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants