-
Notifications
You must be signed in to change notification settings - Fork 63
feat: Add credential test with DNS retry logic #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@SujeethJinesh Please review this PR. My current default for get-credentials is --dns-endpoint, because I see that the create cluster command also defaults to --enable-dns-access. |
|
@scaliby I modified the |
SujeethJinesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just needed confirmation about --force-conflicts
…/AI-Hypercomputer/xpk into lidanny/feature/check_dns_access
|
@DannyLiCom any updates on this? |
@scaliby The check below is showing the error "Kubernetes cluster can't find Job." I don't think this is related to my |
|
@jamOne- If there are no issues, can you help me merge it? It seems authorization is required to merge now. |
|
@jamOne- The check is getting stuck at the verify goldens and appears to be blocked by a "No module named 'ruamel'" error. |
|
|
|
@jamOne- Please review it again! Thanks! |
Fixes / Features
Testing / Documentation
To verify this feature, run the standard
xpk cluster create-pathwayscommand. The new credential test with DNS retry logic will be executed as part of the cluster creation process.https://screenshot.googleplex.com/cTjV7ABQr2omQZd
If a DNS endpoint-related error occurs, the following message will be displayed, followed by an automatic retry:
https://screenshot.googleplex.com/BunMupVA8Yp998o
However, because the --enable-dns-access flag is present by default, the error mentioned above will not appear.