Fix provisioning 1x1 and 1x1x1 topologies #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaliby
requested review from
44past4,
BluValor,
FIoannides,
Obliviour,
RoshaniN,
gcie,
pawloch00 and
sharabiani
as code owners
sharabiani
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Currently TPU v6e-1x1 and TPU tpu7x-1x1x1 topologies cannot be provisioned due to
placement-type,num-nodesandtpu-typeparameters added when creatingnode-pool. This change removes that parameter when topology product is 1.Testing / Documentation
Tested provisioning with command:
python3 xpk.py cluster create --cluster=xpk-test-v6e-1x1-2 --project=tpu-staging-env-one-vm --tpu-type=v6e-1x1 --zone=us-central1-b --num-nodes=1 --enable-autoprovisioning --on-demand