Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
When cluster is re-created but nodepool numbers are not consecutive numbers and desired node pool size is smaller than the original one, XPK removes nodepools that are above the specified limit.
For instance, when user creates a cluster with
--num-slices=3, it creates a following node pools:Then, a user manually deletes a node pool on the UI or through
gcloudcommand so the list of node pools is as follows:'cluster-np-0', - 'cluster-np-1', 'cluster-np-2',Then, as a user re-runs cluster create with
--num-slices=2, XPK will do propose following changes:Where no changes are expected.
After this change XPK will propose no changes to node pools in the mentioned case.
Testing / Documentation
Change has been covered with unit tests.