Skip to content

Conversation

@scaliby
Copy link
Member

@scaliby scaliby commented Aug 27, 2025

Fixes

When cluster is re-created but nodepool numbers are not consecutive numbers and desired node pool size is smaller than the original one, XPK removes nodepools that are above the specified limit.

For instance, when user creates a cluster with --num-slices=3, it creates a following node pools:

+ 'cluster-np-0',
+ 'cluster-np-1',
+ 'cluster-np-2',

Then, a user manually deletes a node pool on the UI or through gcloud command so the list of node pools is as follows:

'cluster-np-0',
- 'cluster-np-1',
'cluster-np-2',

Then, as a user re-runs cluster create with --num-slices=2, XPK will do propose following changes:

'cluster-np-0',
+ 'cluster-np-1'
- 'cluster-np-2'

Where no changes are expected.

After this change XPK will propose no changes to node pools in the mentioned case.

Testing / Documentation

Change has been covered with unit tests.

  • [y] Tests pass
  • [y] Appropriate changes to documentation are included in the PR

@scaliby scaliby requested a review from SikaGrr as a code owner August 27, 2025 15:14
@scaliby scaliby force-pushed the scaliby/b/434405026 branch from 0e73c45 to c2f902e Compare August 27, 2025 17:00
@scaliby scaliby enabled auto-merge (squash) August 28, 2025 07:51
@scaliby scaliby disabled auto-merge August 28, 2025 08:41
@scaliby scaliby merged commit 0d4c860 into develop Aug 28, 2025
13 of 15 checks passed
@scaliby scaliby deleted the scaliby/b/434405026 branch August 28, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants