Add golden tests to github actions #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaliby
requested review from
44past4,
BluValor,
FIoannides,
Obliviour,
RoshaniN,
SikaGrr,
gcie,
jamOne-,
pawloch00 and
sharabiani
as code owners
scaliby
force-pushed
the
b/445869648
branch
2 times, most recently
from
381943c to
19aee4f
Compare
SikaGrr
approved these changes
Sep 19, 2025
Collaborator
SikaGrr
left a comment
SikaGrr
left a comment
There was a problem hiding this comment.
Nice! Already goldens are proving to be useful: to fix dry run, for start.
scaliby
force-pushed
the
b/445869648
branch
from
19aee4f to
3b2d9ab
Compare
scaliby
force-pushed
the
b/445869648
branch
2 times, most recently
from
998972c to
3fb7f67
Compare
scaliby
force-pushed
the
b/445869648
branch
from
3fb7f67 to
fd90a08
Compare
FIoannides
reviewed
Sep 19, 2025
FIoannides
approved these changes
Sep 19, 2025
FIoannides
added a commit
that referenced
this pull request
Sep 24, 2025
* Update .gitignore (#637) * Add golden tests to github actions (#635) * feat: add execution_context * fix: dry run * feat: do not validate deps in dry_run mode * feat: deterministic file names in dry run * build: integrate golden testing with github actions * build: cleanup codeowners (#639) * feat: add more goldens (#640) * build: simplify dependencies on build_test so it runs faster (#642) * Revert "build: simplify dependencies on build_test so it runs faster (#642)" (#644) This reverts commit 1c603d7. * Add cpu and memory limit flags and use them in Kueue configuration (#648) * Add cpu and memory limit flags and use them in Kueue configuration * Remove print line * Release v0.13.0 * Cpu and memory limits (#651) * Add cpu and memory limit flags and use them in Kueue configuration * Remove print line * Add cpu-limit and memory-limit for other types of cluster creation as well * Release v0.13.0 * Remove args from run_command_for_value (#647) * feat: remove args from run_command_for_value * feat: remove redundant args * Golden buddy improvements (#645) * feat: add command to goldens files * feat: improve output of golden_buddy.sh script * feat: colorful git diff --------- Co-authored-by: Konrad Kaim <31181410+scaliby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Feature integrates golden testing framework with github actions. It also fixes dry mode and makes other changing to ensure command output is deterministic when in
dry_runmode.Hint: Reviewing commit by commit might make more sense here.
Let's get Golden era started!
Testing / Documentation
Tested on github actions.